Implement operations::replace traits for bare objects
#2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to specify the types for the original and updated objects separately. This will make it possible to implement the replace traits for the bare object types too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the implementations for
Handles to use the bare object implementations. This change provides much more flexibility for the replace operations:insertthe intermediate object, which caused issues, if the intermediate object was invalid. Now the insertion is no longer required, making it possible to make the object valid using the chained replaced operation, before inserting it.The
Handleimplementations are still provided, as they are also required in some situation, specifically, some of the replace operations themselves. Maybe this can be addressed, I'm not sure.This is needed to make further progress on #2023.